-
Notifications
You must be signed in to change notification settings - Fork 254
Fix namespace hardcode #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does strauss automatically handle namespace references in use
statements? What about the strings containing \FontLib\Table\...
references around line 400 in this file?
If the issue is around construction of a namespace in a string, you might also look at the Dompdf projecthttps://github.com/[dompdf](https://github.com/dompdf). |
this is exactly related to dompdf. with this fix everything started working for us and it seems like there are no errors yet |
I'm curious why only these lines prove problematic. There is similar logic in elsewhere in FontLib as well as in Dompdf that builds a string containing a class reference. I would expect similar issues there. I suppose it's possible you're not hitting those in this library and that only FontLib is impacted because another dependency in your project is using the "FontLib" namespace. |
Maybe. There are no more moments like this in this library? |
In the file you modified there's this block:
and in Dompdf there's a few, like this one:
I'm fine to accept the change you made and wait to resolve others when they crop up. I'm not familiar with the tool you're using so I don't know what best practice would be to prevent potential rename misses. And I'm not planning to spend a lot of time researching it since it's not a primary usage scenario. |
When we prefix namespaces with https://github.com/BrianHenryIE/strauss problems arise